Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainCI for the SDK release went red in the live E2E job after@transloadit/node@4.10.8was published. The package verify/build/unit/lockfile jobs all passed; the failing job wastest/e2e/cli/assemblies-create.test.ts, and repeated runs failed on different live assembly-create cases.A scheduled
mainrun ona3b9b56failed the same live suite earlier on June 18, before the tus rejection fix and release commits, so this is not caused by the SDK tus change.What
filesand not eageruploads.Verification
corepack yarn workspace @transloadit/node test:unit --run ./test/unit/cli/assemblies-create.test.tscorepack yarn verify