fix(ui): apply dark-mode support to remaining app layouts#188
Merged
Conversation
Several preference dialogs/lists and the GPS status screen never picked up the day/night theme added in #185 - they hardcoded @color/white, raw hex backgrounds, or a fixed dialog_card_background hex value instead of the theme-aware resource, so they stayed light-themed regardless of the app's dark-mode setting. - activity_gps_status.xml: fully hardcoded hex screen, converted to theme attributes/colors - dialog_dtc/dialog_trip/dialog_vehicle_metadata/dialog_screen_lock and their item_* list rows: swapped @color/white and raw hex backgrounds for the already day/night-aware @color/dialog_card_background - dialog_pid.xml: one of its two cards hardcoded the light-mode hex value of dialog_card_background directly instead of referencing it, and its toolbar forced ThemeOverlay.AppCompat.Light regardless of theme - @color/gray_dark text on now-dark-capable backgrounds had unreadable contrast; swapped to textColorPrimary/textColorSecondary - added shared divider_color and surface_variant color pairs to replace repeated #FF909090/#E0E0E0/#F0F4F8 hardcodes Deliberately left the gauge/dashboard/graph rendering surfaces and the main activity's persistent chrome untouched - those are an intentional always-dark instrument-cluster look, not a dark-mode gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several preference dialogs/lists and the GPS status screen never picked up the day/night theme added in #185 - they hardcoded @color/white, raw hex backgrounds, or a fixed dialog_card_background hex value instead of the theme-aware resource, so they stayed light-themed regardless of the app's dark-mode setting.
Deliberately left the gauge/dashboard/graph rendering surfaces and the main activity's persistent chrome untouched - those are an intentional always-dark instrument-cluster look, not a dark-mode gap.