feat(pid-edit): add CAN Network override, required-field validation, #189
Merged
Conversation
…and list bug fixes Add a CAN Network dropdown (MS_CAN/HS_CAN/CH_CAN, defaulting to none) to the PID add/edit dialog, wired into PidDefinition.Overrides. Extend the required-field validation to also cover Min/Max. Fix newly created custom PIDs not appearing in the list (missing group assignment, and ECU-support check incorrectly applied to user-defined PIDs). Fix Select All/Deselect All not refreshing the list due to a StateFlow no-op update. Hide the list Save button in edit/alert mode since those dialogs persist directly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and list bug fixes
Add a CAN Network dropdown (MS_CAN/HS_CAN/CH_CAN, defaulting to none) to the PID add/edit dialog, wired into PidDefinition.Overrides. Extend the required-field validation to also cover Min/Max. Fix newly created custom PIDs not appearing in the list (missing group assignment, and ECU-support check incorrectly applied to user-defined PIDs). Fix Select All/Deselect All not refreshing the list due to a StateFlow no-op update. Hide the list Save button in edit/alert mode since those dialogs persist directly.