feat(pid-edit): add JavaScript formula validator#190
Merged
Conversation
…g layout Validate the formula field by actually compiling and evaluating it with the same JS engine used at runtime (rhino), binding dummy values only for the letters (A, B, C...) that the configured Parameters count would provide - catching both syntax errors and out-of-range parameter references. Formula is now a required field. Add an inline explanation of how Parameters maps to formula variables, and rename the "Length" field to "Parameters" to better reflect its meaning. Also regroup the add/edit PID dialog fields into clearer paired rows: Mode+CAN Header, PID Code+CAN Network, Long Description+Value Type, and Parameters+Units / Min+Max. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the formula field by actually compiling and evaluating it with the same JS engine used at runtime (rhino), binding dummy values only for the letters (A, B, C...) that the configured Parameters count would provide - catching both syntax errors and out-of-range parameter references. Formula is now a required field. Add an inline explanation of how Parameters maps to formula variables, and rename the "Length" field to "Parameters" to better reflect its meaning.
Also regroup the add/edit PID dialog fields into clearer paired rows: Mode+CAN Header, PID Code+CAN Network, Long Description+Value Type, and Parameters+Units / Min+Max.