feat(adapter): auto-apply required settings for VGate vLinker MS#193
Merged
Conversation
Selecting VGATE_VLINKER_MS as the adapter type now automatically sets continue-on-error, init protocol (CAN_USER1), and init sequence (HS_CAN), since this adapter requires them to work correctly. Informs the user via a dialog listing what was applied. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Selecting VGATE_VLINKER_MS now also registers a DRI mapping (mode 11: TRW_CLIMATE_CONTROL -> 18DA98F1) via DiagnosticRequestIDManager, alongside the previously auto-applied adapter settings. Bump version codes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Revert now restores continue-on-error/init-protocol/init-sequence to the current profile's own value, not a hardcoded literal. Add Profile.getProfileDefaultValue()/getProfileValue() to read initial values straight from the bundled .properties assets, since saveCurrentProfile() mirrors live (possibly overridden) Prefs back into "<profileId>.<key>" entries, making Prefs itself an unreliable source for the profile's true initial value. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
oss.sonatype.org's legacy snapshots host was permanently shut down by Sonatype, so it now errors instead of a clean 404. Gradle disables a repository after an error like that and fails the build before it can fall through to jitpack.io, where MPAndroidChart:v3.1.0 actually resolves from, breaking CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting VGATE_VLINKER_MS as the adapter type now automatically sets continue-on-error, init protocol (CAN_USER1), and init sequence (HS_CAN), since this adapter requires them to work correctly. Informs the user via a dialog listing what was applied.