chore(deps): downgrade tally from v4 to v3.5.8#224
Merged
Conversation
Align with go-code uberfx/tallyfx, which injects tally.Scope from github.com/uber-go/tally rather than tally/v4.
JamyDev
approved these changes
Jun 9, 2026
behinddwalls
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align with go-code uberfx/tallyfx, which injects tally.Scope from github.com/uber-go/tally rather than tally/v4.
Why?
Currently, this repo uses tally/v4, but we use v3 internally. The interface is the same but the types are not compatible.
What?
Swap to version of tally used internally
Test Plan