refactor(retracer): split callback into smaller functions#25
Draft
Copilot wants to merge 5 commits into
Draft
Conversation
Copilot created this pull request from a session on behalf of
Hyask
June 16, 2026 10:51
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
callbackmethod insrc/retracer.pyhad grown to ~720 lines, mixing core decompression, gdb validation, retraceability checks, and the apport-retrace invocation in a single function.Extracts five self-contained helpers from
callback, each in its own commit, with no behavior change (control flow, metrics, logging, and error handling preserved):build_report— builds an apportReportfrom the Cassandra columns.decompress_core— decompresses the core dump to disk; returns success.gdb_core_check— validates the core dump via gdb; returns whether it's a usable core.check_retraceable— determines release/architecture retraceability and validity.run_apport_retrace— sets up the sandbox/cache and runsapport-retrace, returning(proc, out, err, day_key, retracing_start_time).callbacknow reads as a sequence of guarded steps, e.g.:callbackshrinks from ~727 to ~619 lines.Notes for reviewers
run_apport_retracekeeps the original sandbox/cachefinallycleanup and re-raises setup failures, so the caller's propagation is unchanged.callback.