fix: sequence ESO install before Keycloak secret sync#154
Open
mlorenzofr wants to merge 2 commits into
Open
Conversation
mlorenzofr
marked this pull request as draft
July 10, 2026 15:51
…lSecrets Keycloak depends on ExternalSecrets that require the External Secrets Operator to be installed and reconciling. Without explicit ordering, rh-keycloak could sync before ESO was ready, leaving admin and database secrets missing when the Keycloak CR started. - Add sync-wave 26 to the external-secrets-operator OperatorGroup - Add sync-wave 27 to the openshift-external-secrets-operator subscription - Add a PreSync hook to the rh-keycloak chart that waits for the ESO webhook to have ready endpoints before ArgoCD syncs the ExternalSecret resources. Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
mlorenzofr
force-pushed
the
eso-rhbk-deps
branch
from
July 14, 2026 09:34
6ad1dd0 to
df0b393
Compare
mlorenzofr
marked this pull request as ready for review
July 14, 2026 09:37
sabre1041
requested changes
Jul 14, 2026
sabre1041
left a comment
sabre1041
left a comment
Collaborator
There was a problem hiding this comment.
Functionality as it is today works. A few suggestons
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Collaborator
Author
|
@sabre1041 changes ready for a new review |
p-rog
approved these changes
Jul 17, 2026
p-rog
left a comment
p-rog
left a comment
Collaborator
There was a problem hiding this comment.
I hit this race condition as well and this patch directly fixes the race condition problem and the implementation is clean. IMHO good to go and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keycloak depends on
ExternalSecretsthat require the External Secrets Operator to be installed and reconciling. Without explicit ordering,rh-keycloakcould sync before ESO was ready, leaving admin and database secrets missing when theKeycloakCR started.PreSynchook to therh-keycloakchart that waits for the ESO webhook to have ready endpoints before ArgoCD syncs theExternalSecretresources.