fix: dynamic OIDC clientId via Helm helpers for qtodo and rh-keycloak#160
Open
mlorenzofr wants to merge 1 commit into
Open
fix: dynamic OIDC clientId via Helm helpers for qtodo and rh-keycloak#160mlorenzofr wants to merge 1 commit into
mlorenzofr wants to merge 1 commit into
Conversation
Add template helpers that derive the OIDC client ID from the provider and authentication method instead of requiring a static override. When client assertion is enabled the SPIFFE URI is generated from the cluster domain, namespace and service account. The rh-keycloak chart feeds the resolved value into a realmPlaceholder secret so the Keycloak realm import picks it up at deploy time. Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
p-rog
approved these changes
Jul 20, 2026
Collaborator
There was a problem hiding this comment.
LGTM.
It's not that simple like my fix to the OIDC clientID #157, but from the architecture perspective your approach is more "purer" and aligns the client identity across the stack (ClientId = SPIFFE ID = JWT sub — all three aligned).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add template helpers that derive the OIDC client ID from the provider and authentication method instead of requiring a static override. When client assertion is enabled the SPIFFE URI is generated from the cluster domain, namespace and service account. The
rh-keycloakchart feeds the resolved value into arealmPlaceholdersecret so the Keycloak realm import picks it up at deploy time.This PR addresses the issues introduced with #155
Alternative solution #157