chore: add mx::api feature skills#176
Merged
Merged
Conversation
gen-quality
|
Add a skill that understands how MusicXML features can be added to the mx::api layer.
New `python3 -m audit` tool (audit/) inventories which MusicXML elements and attributes each corpus file uses, so we can compare the corpus against what the mx::api layer exposes. It writes a *.features.xml sidecar per corpus file and a data/corpus.xml aggregate (ordered by real-world usage, distinguishing wild from synthetic). The corert, api, Go, and C corpus discoverers now skip these audit artifacts (*.features.xml and corpus.xml) so they are never parsed as MusicXML scores; the corert pinned file count is unchanged. Adds the api-feature-audit skill, which uses the inventory to find mx::api enum bugs (a value present in an mx::core enum but missing from the parallel mx::api enum is silently dropped) and feature gaps. Run with `make audit`.
Generated by `python3 -m audit all`: a *.features.xml sidecar for each of the 829 round-tripped corpus files, listing the elements and attributes it uses, plus the data/corpus.xml aggregate. The round-trip suites skip these files.
Add the api-feature-audit outputs: data/api.features.xml (view 3 of the feature surface, 318 features) and docs/ai/api-feature-audit.md (prioritized findings). Enum diff of the Converter EnumMap tables finds 9 tables that drop core members on read (3 are one-line table fixes where the api enum already has the slot). High-use wild gaps: print, credit, sound, defaults fonts.
webern
force-pushed
the
api-features-skill
branch
from
117aeac to
a7a44f0
Compare
gen-quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add skills, audit files, and an audit report to help us understand what is supported in
mx::apiand what needs work.