api: fix notehead value fa up silently missing#177
Merged
Conversation
`noteheadMap` in Converter.cpp was missing the faUp entry, so any note with a <notehead>fa up</notehead> in MusicXML was read back as Notehead::none (silent data loss). Add the missing row and a round-trip test that verifies both the write path (XML contains "fa up") and the read path (notehead survives the trip as faUp).
gen-quality
|
Coverage reportCore-dev coverage
|
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 77.9% | 28539 / 36619 |
| Functions | 74.4% | 6360 / 8547 |
| Branches | 50.7% | 22672 / 44725 |
API coverage src/private/mx/{api,impl,utility}/
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 68.7% | 4735 / 6896 |
| Functions | 54.8% | 1475 / 2692 |
| Branches | 40.3% | 3850 / 9558 |
Core HTML report | API HTML report
Commit f3f9d14e2eac6a802f2bfa6eea887e9da81a8b23.
webern
changed the title
This was referenced Jun 16, 2026
webern
added a commit
that referenced
this pull request
Jun 16, 2026
## Summary The `api-feature-audit` doc now doubles as a tracker. Added a Tracker table mapping every audited item to its GitHub issue or PR, plus a pointer near the top to the parent tracker issue. The three section-1a enum bugs are marked done against their fix PRs (#177, #178, #179). The remaining 16 items now have issues (#181-#196), all linked as sub-issues of #159, which was rewritten into a parent tracker with live checkboxes. ## References - Progresses #159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noteheadMapinConverter.cppwas missing thefaUpentry, so any MusicXML note with<notehead>fa up</notehead>was silently read back asNotehead::none(data loss){core::NoteheadValue::faUp(), api::Notehead::faUp}noteheadFaUpRoundtrip) that verifies both the write path (serialized XML contains"fa up") and the read path (notehead survives deserialization asfaUp)Test plan
make testpasses (219 test cases, 3917 assertions — all green)make fmt/make checkpasses (no format diff)noteheadFaUpRoundtrip_NoteDataconfirmed RED before fix, GREEN after