pia: fix sound id clarinet piccolo silently missing#179
Merged
Conversation
Add the missing windReedClarinetPiccolo enum value to api::SoundID and the corresponding row in Converter::instrumentMap. Without the map entry, any MusicXML file carrying instrument-sound wind.reed.clarinet.piccolo was silently read back as api::SoundID::unspecified (data loss). Covered by two new Converter unit tests (core->api and api->core).
gen-quality
|
Coverage reportCore-dev coverage
|
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 77.9% | 28539 / 36619 |
| Functions | 74.4% | 6360 / 8547 |
| Branches | 50.7% | 22672 / 44725 |
API coverage src/private/mx/{api,impl,utility}/
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 68.7% | 4735 / 6896 |
| Functions | 54.8% | 1475 / 2692 |
| Branches | 40.3% | 3850 / 9558 |
Core HTML report | API HTML report
Commit 30a4e0c4ab2fa0ff89242cd3a14c52da597cabd8.
webern
changed the title
This was referenced Jun 16, 2026
webern
added a commit
that referenced
this pull request
Jun 16, 2026
## Summary The `api-feature-audit` doc now doubles as a tracker. Added a Tracker table mapping every audited item to its GitHub issue or PR, plus a pointer near the top to the parent tracker issue. The three section-1a enum bugs are marked done against their fix PRs (#177, #178, #179). The remaining 16 items now have issues (#181-#196), all linked as sub-issues of #159, which was rewritten into a parent tracker with live checkboxes. ## References - Progresses #159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(cat <<'EOF'
Summary
api::SoundID::windReedClarinetPiccolowas missing from the enum insrc/include/mx/api/SoundID.h{core::SoundID::windReedClarinetPiccolo(), api::SoundID::windReedClarinetPiccolo}was absent fromConverter::instrumentMapinConverter.cppinstrument-sound wind.reed.clarinet.piccolowas silently read back asapi::SoundID::unspecified(data loss on round-trip)This is the "one-line table fix" for
windReedClarinetPiccolodescribed indocs/ai/api-feature-audit.md§1a.Changes
src/include/mx/api/SoundID.h: addwindReedClarinetPiccolobetweenwindReedClarinetEflatandwindReedClarinetPiccoloAflatsrc/private/mx/impl/Converter.cpp: add the matching row toinstrumentMapsrc/private/mxtest/impl/ConverterSoundIDTest.cpp: new test file with two cases (core→api and api→core) that were RED before the fix and GREEN afterTest plan
make fmtpasses (clang-format clean)make checkpasseswindReedClarinetPiccolo_coreToApi_ConverterSoundIDandwindReedClarinetPiccolo_apiToCore_ConverterSoundIDconfirmed RED before fix, GREEN after./build/api/mxtest— all 3914 assertions in 220 test cases pass