feat: add -webrpcHeader opt-out + exercise Quantity alias#2
Open
klaidliadon wants to merge 1 commit into
Open
Conversation
- add `-webrpcHeader=false` to omit the `Webrpc` version header from client requests (parity with the other generators; consts and server responses unchanged, matching gen-typescript semantics) - use the `Quantity` alias as an `Item` field so alias serde is exercised end-to-end (wire shape + roundtrip), not merely defined - document `-webrpcHeader` in the README options table Verified: `make generate` clean diff (only the new field + hash), `make test` passes, and `-webrpcHeader=false` output omits the client header and parses as valid Python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two parity follow-ups for the Python generator (now that it's released at v0.1.0):
-webrpcHeader=falseopt-out — every other generator gates theWebrpcversion header on$opts.webrpcHeader, but gen-python hardcoded it always-on. Added the flag (default on), gating the client request header. Consts and server responses are unchanged, matching gen-typescript's semantics.Quantityalias — it was defined in the example schema but never referenced, so onlyItemNamewas actually covered. Added aquantity: Quantityfield toItemso the alias round-trips through serde (wire shape + decode), with assertions in the test.Also documents
-webrpcHeaderin the README options table.Verified locally:
make generate→ clean diff (golden reproduces; only the new field + schema hash changed)make test→ROUNDTRIP OK-webrpcHeader=falseomits theWebrpcclient header and the output parses as valid PythonTargets v0.1.1.