fix(url): double-encode dots as %252E for NGINX compatibility#1493
Open
matteotrubini wants to merge 2 commits into
Open
fix(url): double-encode dots as %252E for NGINX compatibility#1493matteotrubini wants to merge 2 commits into
matteotrubini wants to merge 2 commits into
Conversation
In certain NGINX configurations, unencoded dots in URLs may trigger asset-serving rules, resulting in 404 errors. rawurlencode() skips dots, but RFC 3986 allows dot encoding, so we manually double-encode them.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughIn Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@modules/system/classes/ImageResizer.php`:
- Around line 586-588: The identifier generation in the ImageResizer class is
based on the original URL with unencoded dots, but the actual encoded URL being
sent has dots replaced with %252E. This causes a validation mismatch in
getValidResizedUrl() where the hash comparison fails because the identifier was
generated from a different URL format than what is being validated. Move the
identifier generation (the hash_hmac call that creates the identifier) to occur
AFTER the dot replacement on line 588, so that the identifier is computed from
the modified $resizedUrl that contains %252E instead of literal dots, ensuring
consistency between the encoded URL and its corresponding identifier throughout
the validation process.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0542cb98-530f-4e7b-a547-f06ab95ca767
📒 Files selected for processing (1)
modules/system/classes/ImageResizer.php
Member
|
@matteotrubini can you add tests for this? |
matteotrubini
force-pushed
the
fix/resize-dot-urlencode
branch
from
4a54115 to
0463993
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain NGINX configurations, unencoded dots in URLs may trigger asset-serving rules, resulting in 404 errors. rawurlencode() skips dots, but RFC 3986 allows dot encoding, so we manually double-encode them.
Summary by CodeRabbit