Check Include path truncation in sshd config#1023
Open
ejohnstown wants to merge 1 commit into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1023
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Prevents silently truncated Include paths in wolfsshd config handling by validating WSNPRINTF results and returning WS_INVALID_PATH_E when the generated path does not fit.
Changes:
- Consolidates duplicate
WSNPRINTFcalls into a single path-build operation. - Detects over-long include paths and returns
WS_INVALID_PATH_Einstead of proceeding with a truncated path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HandleInclude built the wildcard include path with WSNPRINTF without checking the result, silently truncating over-long paths (flagged by GCC 12 as -Werror=format-truncation). Merge the duplicate WSNPRINTF calls and return WS_INVALID_PATH_E when the path does not fit.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1023
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HandleInclude built the wildcard include path with WSNPRINTF without checking the result, silently truncating over-long paths (flagged by GCC 12 as -Werror=format-truncation). Merge the duplicate WSNPRINTF calls and return WS_INVALID_PATH_E when the path does not fit.