Add network_address option to connect to the RCP over TCP#2
Open
tube0013 wants to merge 1 commit into
Open
Conversation
Adds a network_address config option (tcp://host:port) that takes priority over the device serial-port picker when set, wired through to ziggurat-server's --device flag (zigpy/ziggurat#39, merged). Wi-Fi-connected radios are not recommended. The device field is still required by the add-on's config form even when network_address is set (the form won't validate otherwise), but its value is functionally ignored in that case. Targets the next zigpy/ziggurat release rather than the current 0.1.0 on crates.io, which predates this change; the ZIGGURAT_VERSION build arg will need confirming against whatever version is actually published, since zigpy/ziggurat's publish workflow stamps the version from the release tag rather than from its Cargo.toml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
I've run into the same config validation issue with my flasher addons, it's annoying lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a network_address config option (tcp://host:port) that takes priority over the device serial-port picker when set, wired through to ziggurat-server's --device flag (zigpy/ziggurat#39, merged). Wi-Fi-connected radios are not recommended.
The device field is still required by the add-on's config form even when network_address is set (the form won't validate otherwise), but its value is functionally ignored in that case.
Targets the next zigpy/ziggurat release rather than the current 0.1.0 on crates.io, which predates this change; the ZIGGURAT_VERSION build arg will need confirming against whatever version is actually published, since zigpy/ziggurat's publish workflow stamps the version from the release tag rather than from its Cargo.toml.