Fix Mactrack integration dependencies#338
Open
somethingwithproof wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions integration workflow to be less dependent on Ubuntu’s apt-provided Apache/PHP module packaging and to ensure Mactrack’s Composer-managed runtime dependencies (when present) are installed before the plugin is enabled in the Cacti E2E flow.
Changes:
- Remove
libapache2-mod-php${{ matrix.php }}from apt dependencies to avoid unavailable Ubuntu-versioned packages. - Add a workflow step to run
composer install --no-devin the Mactrack plugin directory (guarded bycomposer.jsonexistence) prior to plugin enablement.
Comment on lines
+168
to
+173
| - name: Install Mactrack Composer Dependencies | ||
| run: | | ||
| cd ${{ github.workspace }}/cacti/plugins/mactrack | ||
| if [ -f composer.json ]; then | ||
| sudo composer install --no-dev --prefer-dist --no-progress --no-interaction | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkThis is deliberately separate from #336 so the release-hardening change remains focused.