Skip to content

Fix Mactrack integration dependencies #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somethingwithproof wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix Mactrack integration dependencies #338

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
378a103
Fix Mactrack integration dependencies
somethingwithproof Jul 14, 2026
d9dc0de
Exclude Composer vendor files from linting
somethingwithproof Jul 14, 2026
601a787
test: exclude Composer vendor tree from syntax checks
somethingwithproof Jul 14, 2026
c7eda37
test: exclude Composer vendor tree from syntax checks
somethingwithproof Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/plugin-ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
run: sudo apt-get update

- name: Install System Dependencies
run: sudo apt-get install -y apache2 snmp snmpd rrdtool fping libapache2-mod-php${{ matrix.php }}
run: sudo apt-get install -y apache2 snmp snmpd rrdtool fping

- name: Start SNMPD Agent and Test
run: |
Expand Down Expand Up @@ -164,7 +164,14 @@ jobs:
run: |
cd ${{ github.workspace }}/cacti
sudo php cli/install_cacti.php --accept-eula --install --force


- name: Install Mactrack Composer Dependencies
run: |
cd ${{ github.workspace }}/cacti/plugins/mactrack
if [ -f composer.json ]; then
sudo composer install --no-dev --prefer-dist --no-progress --no-interaction
fi

- name: Install mactrack Plugin
run: |
cd ${{ github.workspace }}/cacti
Expand All @@ -182,10 +189,8 @@ jobs:
- name: Check PHP Syntax for Plugin
run: |
cd ${{ github.workspace }}/cacti/plugins/mactrack
if find . -name '*.php' -exec php -l {} 2>&1 \; | grep -iv 'no syntax errors detected'; then
echo "Syntax errors found!"
exit 1
fi
set -o pipefail
find . -path './vendor' -prune -o -type f -name '*.php' -print0 | xargs -0 -r -n1 php -l

- name: Remove the plugins directory exclusion from the .phpstan.neon
run: sed '/plugins/d' -i .phpstan.neon
Expand Down
Loading