London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Implement and Rewrite Tests by Yonatanteklemariam · Pull Request #1381 · CodeYourFuture/Module-Structuring-and-Testing-Data

Yonatanteklemariam · 2026-06-22T12:10:01Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Defined a new function based on the instruction and wrote tests to verify the output matches the expected target output.

…expected

cjyuan

Code looks good.

Can you revert the changes made in the 2-practice-tdd folder? I think they belong to a separate PR.

Yonatanteklemariam · 2026-06-27T15:17:04Z

Code looks good.

Can you revert the changes made in the 2-practice-tdd folder? I think they belong to a separate PR.

yes, I've removed the tdd folder from the changed files and fixed it.

Remove check for zero numerator in isProperFraction function.

cjyuan

Have you rerun the test scripts after you made changes? It's a good practice to run the test scripts before making a commit or pushing the commits to GitHub.

cjyuan · 2026-06-28T19:08:25Z

+  if (Number.isNaN(numerator) || Number.isNaN(denominator)) {
+    return false;
+  }


Note: A stronger check might be !Number.isFinite() (or !Number.isInteger() if you only allow integer numerator and denominator).

No change needed.

cjyuan · 2026-06-29T02:53:21Z

I don't see any new commits on this branch. Have you made any change to address this comment: #1381 (review) ?

Added checks for finite and integer values of numerator and denominator.

github-actions · 2026-07-03T11:41:09Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/4-stretch/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-07-03T11:41:12Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/4-stretch/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

…mariam/Module-Structuring-and-Testing-Data into coursework/Sprint-3

github-actions · 2026-07-03T11:50:46Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/4-stretch/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-07-03T11:59:12Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/4-stretch/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-07-03T12:14:57Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/4-stretch/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-07-03T12:15:07Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/4-stretch/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-07-03T12:22:53Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/4-stretch/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan

I don't see how your implementation can pass your tests. That's why I asked if you had reran your tests after you made changes to make sure everything works as expected.

cjyuan · 2026-07-03T19:08:48Z

+  if (!Number.isFinite(numerator) || !Number.isFinite(denominator)) {
+    return false;
+  }
+  if (!Number.isInteger(numerator) || !Number.isInteger(denominator)) {
+    return false;
+  }


If a number is not finite, then the number is also not an integer. One of these checks is redundant.

github-actions · 2026-07-03T19:12:07Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/4-stretch/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan · 2026-07-03T19:16:28Z

To pass the validation bot check, you need to rename this branch to the name specified in the issue (backlog): #6

Refactor isProperFraction to validate integers instead of finite numbers.

Fix syntax error in isProperFraction function.

written tests to check whether a given angle matches the expected output

0ef19ec

Yonatanteklemariam added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels Jun 22, 2026

written jest test scripts for all the three functions

df94ea4

Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 27, 2026

written jest tests for all the three functions and tests returned as …

baa070c

…expected

cjyuan reviewed Jun 27, 2026

View reviewed changes

Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js Outdated

Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 27, 2026

This comment has been minimized.

Sign in to view

Yonatanteklemariam added 3 commits June 27, 2026 15:29

removed the redundant and unreachable codes

7bcf484

fix: revert files to orginal

a0be617

fix; revert to original

8a5a9f0

Refactor isProperFraction to remove zero numerator check

033144b

Remove check for zero numerator in isProperFraction function.

Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 28, 2026

cjyuan reviewed Jun 28, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 28, 2026

Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 29, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 29, 2026

Enhance isProperFraction with input validation

e0e964d

Added checks for finite and integer values of numerator and denominator.

Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026

Yonatanteklemariam added 2 commits July 3, 2026 12:48

edited

c4449e6

Merge branch 'coursework/Sprint-3' of https://github.com/Yonatantekle…

6b77070

…mariam/Module-Structuring-and-Testing-Data into coursework/Sprint-3

Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026

Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026

Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 3, 2026

cjyuan reviewed Jul 3, 2026

View reviewed changes

cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jul 3, 2026

Yonatanteklemariam added 2 commits July 3, 2026 20:43

Update isProperFraction validation logic to accept only integers.

424fb3a

Refactor isProperFraction to validate integers instead of finite numbers.

Correct syntax in isProperFraction function

70485c6

Fix syntax error in isProperFraction function.

Yonatanteklemariam closed this Jul 3, 2026

Yonatanteklemariam deleted the coursework/Sprint-3 branch July 3, 2026 19:56

Yonatanteklemariam mentioned this pull request Jul 4, 2026

London | 26-May-ITP | Yonatan Teklemariam | Sprint 3 | implement and rewrite tests #1452

Open

4 tasks

Uh oh!

Uh oh!

Conversation

Yonatanteklemariam commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Yonatanteklemariam commented Jun 27, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

cjyuan commented Jul 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Yonatanteklemariam commented Jun 22, 2026 •

edited

Loading

cjyuan Jun 28, 2026 •

edited

Loading