feat(cli): add GPU count requests#1812
Open
elezar wants to merge 4 commits into
Open
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-1812.docs.buildwithfern.com/openshell |
5 tasks
Collaborator
|
/ok to test abe5b79 |
Collaborator
|
/ok to test abe5b79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CLI and API support for counted GPU sandbox requests.
--gpu-deviceand--gpu-countboth imply a GPU request, and Kubernetes receives countednvidia.com/gpuresource limits while unsupported drivers reject count-based selection explicitly.Related Issue
Part of #1444. Related to #1338 and #1156. Follow-up GPU support preflight semantics are tracked in #1807.
Changes
--gpu-deviceimply--gpuin CLI-created sandbox requests.--gpu-countto the CLI, public sandbox proto, and compute-driver proto.gpu_countorgpu_deviceis present.nvidia.com/gpulimits fromgpu_countand reject explicitgpu_devicerequests for Kubernetes.gpu_countrequests in Docker, Podman, and VM driver paths, while allowing VMgpu_count = 1.Testing
mise run pre-commitpassesFocused checks also run during local review:
mise x -- cargo test -p openshell-cli gpu_countmise x -- cargo test -p openshell-cli gpu_devicemise x -- cargo test -p openshell-server gpu_countmise x -- cargo test -p openshell-server gpu_devicemise x -- cargo test -p openshell-driver-kubernetes gpumise x -- cargo test -p openshell-driver-docker gpu_countmise x -- cargo test -p openshell-driver-podman gpu_countmise x -- cargo test -p openshell-driver-vm gpu_countChecklist