Skip to content

feat(cli): add GPU count requests#1812

Open
elezar wants to merge 4 commits into
mainfrom
1444-gpu-cli-count/elezar
Open

feat(cli): add GPU count requests#1812
elezar wants to merge 4 commits into
mainfrom
1444-gpu-cli-count/elezar

Conversation

@elezar

@elezar elezar commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

Adds CLI and API support for counted GPU sandbox requests. --gpu-device and --gpu-count both imply a GPU request, and Kubernetes receives counted nvidia.com/gpu resource limits while unsupported drivers reject count-based selection explicitly.

Related Issue

Part of #1444. Related to #1338 and #1156. Follow-up GPU support preflight semantics are tracked in #1807.

Changes

  • Make --gpu-device imply --gpu in CLI-created sandbox requests.
  • Add --gpu-count to the CLI, public sandbox proto, and compute-driver proto.
  • Normalize GPU request intent in the gateway when gpu_count or gpu_device is present.
  • Render Kubernetes nvidia.com/gpu limits from gpu_count and reject explicit gpu_device requests for Kubernetes.
  • Reject unsupported gpu_count requests in Docker, Podman, and VM driver paths, while allowing VM gpu_count = 1.
  • Update GPU request docs and driver architecture notes.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Focused checks also run during local review:

  • mise x -- cargo test -p openshell-cli gpu_count
  • mise x -- cargo test -p openshell-cli gpu_device
  • mise x -- cargo test -p openshell-server gpu_count
  • mise x -- cargo test -p openshell-server gpu_device
  • mise x -- cargo test -p openshell-driver-kubernetes gpu
  • mise x -- cargo test -p openshell-driver-docker gpu_count
  • mise x -- cargo test -p openshell-driver-podman gpu_count
  • mise x -- cargo test -p openshell-driver-vm gpu_count

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

elezar added 4 commits June 8, 2026 15:09
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar requested a review from a team as a code owner June 8, 2026 13:10
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

@mrunalp

mrunalp commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/ok to test abe5b79

@TaylorMutch

Copy link
Copy Markdown
Collaborator

/ok to test abe5b79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants