forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 221
feat(intro): Add short Intro Logo for The Super Hackers team #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+445
−248
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5a57950
refactor(intro): Move intro related code to new file and class (#2267)
xezon 5b2f382
refactor(intro): Simplify the intro state machine in Intro class (#2267)
xezon c01ae4a
fix(intro): Remove non functional copyright string and simplify logo …
xezon e7635cf
tweak(intro): Remove superfluous legal page window from intro sequenc…
xezon c8e1367
feat(intro): Add short Intro Logo for The Super Hackers team (#2267)
xezon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /* | ||
| ** Command & Conquer Generals Zero Hour(tm) | ||
| ** Copyright 2026 TheSuperHackers | ||
| ** | ||
| ** This program is free software: you can redistribute it and/or modify | ||
| ** it under the terms of the GNU General Public License as published by | ||
| ** the Free Software Foundation, either version 3 of the License, or | ||
| ** (at your option) any later version. | ||
| ** | ||
| ** This program is distributed in the hope that it will be useful, | ||
| ** but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| ** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| ** GNU General Public License for more details. | ||
| ** | ||
| ** You should have received a copy of the GNU General Public License | ||
| ** along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <vector> | ||
|
|
||
| class DisplayString; | ||
| class Image; | ||
|
|
||
| class Intro | ||
| { | ||
| enum IntroState | ||
| { | ||
| IntroState_Start, | ||
| IntroState_EALogoMovie, | ||
| IntroState_TheSuperHackersWait, | ||
| IntroState_TheSuperHackers, | ||
| IntroState_SizzleMovieWait, | ||
| IntroState_SizzleMovie, | ||
| IntroState_Done, | ||
| }; | ||
|
|
||
| struct DisplayEntity | ||
| { | ||
| DisplayEntity() | ||
| : displayString(nullptr) | ||
| , image(nullptr) | ||
| , sizeX(10) | ||
| , sizeY(10) | ||
| , centerOffsetY(0) | ||
| {} | ||
| ~DisplayEntity(); | ||
|
|
||
| DisplayString* displayString; // is owner | ||
| const Image* image; | ||
| Int sizeX; | ||
| Int sizeY; | ||
| Int centerOffsetY; | ||
| }; | ||
|
|
||
| public: | ||
|
|
||
| Intro(); | ||
|
|
||
| void update(); | ||
| void draw(); | ||
|
|
||
| Bool isDone() const { return m_currentState == IntroState_Done; } | ||
|
|
||
| private: | ||
|
|
||
| void enterNextState(); | ||
|
|
||
| void doEALogoMovie(); | ||
| void doTheSuperHackers(); | ||
| void doSizzleMovie(); | ||
| void doPostIntro(); | ||
| void doAsyncWait(UnsignedInt milliseconds); | ||
|
|
||
| void drawDisplayEntities(); | ||
|
|
||
| private: | ||
|
|
||
| IntroState m_currentState; | ||
| UnsignedInt m_allowedStateFlags; | ||
| UnsignedInt m_waitUntilMs; | ||
| UnicodeString m_unicodeStrings[1]; | ||
| std::vector<DisplayEntity> m_displayEntities; | ||
| Real m_fadeValue; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DisplayEntity frees displayString in its destructor but has implicit copy ctor/assignment and lives in a std::vector, maybe free the strings in a ~Intro loop instead? I think this would only be an issue if someone appends a second credits screen though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is not so elegant. It would be solved by making the raw pointer a unique_ptr with c++11. I added a comment for now.