ADFA-4690-Clean-up-capitalization-in-Open-External-Link-dialog-box

[Elissa-AppDevforAll]

Also changed "Proceed" to "Yes" and "Cancel" to "No" because those are the answers to the question being asked.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

📝 Walkthrough

• Updated Open External Link consent dialog capitalization and punctuation.
• Changed button labels from “Proceed”/“Cancel” to “Yes”/“No”.
• Adjusted “don’t ask again” prompt capitalization.
• No notable risks or best-practice violations identified.

Walkthrough

The URL consent dialog resources update its title formatting, changes the action labels to “No” and “Yes,” and adjusts the “Don’t ask again” capitalization. The consent message and %s placeholder remain unchanged.

Changes

URL consent dialog

Layer / File(s)	Summary
Update consent dialog labels resources/src/main/res/values/strings.xml	Updates the dialog title, replaces “Cancel”/“Proceed” with “No”/“Yes,” and changes “Don’t Ask Again” to “Don’t ask again.”

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: hal-eisen-adfa, itsaky-adfa, daniel-adfa

Poem

A rabbit taps “Yes” with a grin,
“No” rests softly beside it.
The title grows tidy and bright,
While prompts keep their lowercase light.
The URL message stays in sight.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: cleanup of capitalization in the Open External Link dialog.
Description check	✅ Passed	The description is directly related and accurately mentions the button label changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-4690-Clean-up-capitalization-in-Open-External-Link-dialog-box

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/src/main/res/values/strings.xml`:
- Line 1218: Restore the warning dialog’s cancel label without changing its
intended “Cancel” action: update the url_consent_cancel resource used by
MainActivity, or switch that dialog to an existing generic cancel resource,
while preserving the URL-consent dialog’s separate negative label as “No”.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 581690d1-23bd-4a0f-b0e9-be7199d8037c

📥 Commits

Reviewing files that changed from the base of the PR and between 8077407 and 263c85b.

📒 Files selected for processing (1)

• resources/src/main/res/values/strings.xml

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep the unrelated warning dialog’s label as “Cancel”.

MainActivity.kt also uses url_consent_cancel for a warning dialog whose negative action is intended to be “Cancel”. This change makes that dialog display “OK”/“No”. Use a dedicated URL-consent negative label or an existing generic cancel resource instead.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@resources/src/main/res/values/strings.xml` at line 1218, Restore the warning
dialog’s cancel label without changing its intended “Cancel” action: update the
url_consent_cancel resource used by MainActivity, or switch that dialog to an
existing generic cancel resource, while preserving the URL-consent dialog’s
separate negative label as “No”.