Skip to content

ADFA-4690-Clean-up-capitalization-in-Open-External-Link-dialog-box #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elissa-AppDevforAll wants to merge 2 commits into
base: stage
Choose a base branch
from
Open

ADFA-4690-Clean-up-capitalization-in-Open-External-Link-dialog-box #1549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352bd8a
Update string capitalization in strings.xml
Elissa-AppDevforAll Jul 13, 2026
263c85b
Update consent dialog button texts
Elissa-AppDevforAll Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions resources/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,11 +1213,11 @@
<string name="back_to_cogo">Back to Code on the Go</string>

<!-- URL Consent Dialog -->
<string name="url_consent_title">Open External Link?</string>
<string name="url_consent_title">Open external link?</string>
<string name="url_consent_message">You are about to leave Code on the Go to open an external link:\n\n%s\n\nDo you want to continue?</string>
<string name="url_consent_cancel">Cancel</string>
<string name="url_consent_proceed">Proceed</string>
<string name="url_consent_dont_ask">Don\'t Ask Again</string>
<string name="url_consent_cancel">No</string>

@coderabbitai coderabbitai Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep the unrelated warning dialog’s label as “Cancel”.

MainActivity.kt also uses url_consent_cancel for a warning dialog whose negative action is intended to be “Cancel”. This change makes that dialog display “OK”/“No”. Use a dedicated URL-consent negative label or an existing generic cancel resource instead.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@resources/src/main/res/values/strings.xml` at line 1218, Restore the warning
dialog’s cancel label without changing its intended “Cancel” action: update the
url_consent_cancel resource used by MainActivity, or switch that dialog to an
existing generic cancel resource, while preserving the URL-consent dialog’s
separate negative label as “No”.

<string name="url_consent_proceed">Yes</string>
<string name="url_consent_dont_ask">Don\'t ask again</string>

<!-- Documentation urls -->
<string name="layout_editor_url">http://localhost:6174/i/layout-top.html</string>
Expand Down
Loading