Friction combine mode for kamino#6409
Open
david-cao-mueller wants to merge 1 commit into
Open
Conversation
david-cao-mueller
requested review from
ClemensSchwarke,
Mayankm96,
Toni-SM,
jtigue-bdai,
kellyguo11,
masoudmoghani,
matthewtrepte,
ooctipus,
ossamaAhmed,
pascal-roth,
peterd-NV and
xyao-nv
as code owners
Contributor
|
Too many files changed for review. ( |
github-actions
Bot
added
documentation
AntoineRichard
approved these changes
Jul 8, 2026
AntoineRichard
left a comment
AntoineRichard
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Are we going to make this more modular?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Option to set Friction Combine Mode for Kamino. This MR needs to be merged first: newton-physics/newton#3382
Fixes # (issue)
Currently average combine mode has been hardcoded.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there