chore(benchmarks): note the format_table/format_markdown column sync#150
Merged
Conversation
The two renderers mirror the same columns, precision, and footer facts in different skins (fixed-width vs Markdown). A one-line pointer in each pins the drift hazard without introducing a shared abstraction that two stable renderers don't yet warrant. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
format_tableandformat_markdownmirror the same 9 columns, per-column precision, and gated-vs-informational footer facts in two skins (fixed-width vs Markdown). Add a one-line pointer in each so an edit to one is a reminder to update the other.Why not factor them out
Reviewed and deliberately not abstracted: with only two renderers and a stable column set, a shared column-descriptor table would cost more indirection than the duplication costs risk (premature DRY). The comment pins the drift hazard for ~zero cost; the break-even for factoring is a genuine third output format or churning columns.
Comment-only, no behavior change. ruff + ty clean, 20/20
tests/test_benchmarks.pypass.🤖 Generated with Claude Code