Skip to content

chore(benchmarks): note the format_table/format_markdown column sync #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Jul 17, 2026
Merged

chore(benchmarks): note the format_table/format_markdown column sync #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions benchmarks/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def to_baseline(results: list[RunResult]) -> dict[str, typing.Any]:

def format_table(results: list[RunResult]) -> str:
"""Render the runs as a human table with a gated-vs-informational footer."""
# Columns/precision/footer facts are mirrored in format_markdown -- keep in sync.
header = (
f"{'scenario':<22} {'msg/s':>9} {'delete/msg':>11} {'WALrec/msg':>11} "
f"{'WALB/msg':>9} {'fpi':>5} {'upd':>7} {'del':>7} {'dead_tup':>9}"
Expand Down Expand Up @@ -135,6 +136,7 @@ def format_markdown(results: list[RunResult], failures: list[str]) -> str:
function only formats -- the exit code is the caller's, so the comment can be
posted on both pass and fail.
"""
# Columns/precision/footer facts are mirrored in format_table -- keep in sync.
verdict = "✅ gate passed" if not failures else "❌ gate FAILED"
lines = ["## Benchmark gate", "", verdict, ""]
if failures:
Expand Down