[TypeDeclaration] Skip recursive dim fetch closure in StrictArrayParamDimFetchRector#8141
Closed
TomasVotruba wants to merge 1 commit into
Closed
[TypeDeclaration] Skip recursive dim fetch closure in StrictArrayParamDimFetchRector#8141TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…mDimFetchRector A closure that feeds a value read from $param[dim] back into itself as the same argument signals an ArrayAccess tree (e.g. Symfony FormView), not a plain array. Adding an 'array' type hint there is a false positive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducer
StrictArrayParamDimFetchRectorgives a false positive on recursive closures that walk anArrayAccesstree (real case: SymfonyFormViewin Mautic'sFormThemeTrait):The rule added
array $formView, which is wrong —FormViewimplementsArrayAccess.Why it happens
The closure param
$formViewis untyped, so PHPStan seesmixedinside the closure; the only proof it is aFormViewlives at the call site, which the rule does not inspect. Seeing just$formView[$name], the rule assumesarray.Fix
Skip when a value read from
$param[dim](directly, or via a variable assigned from it) is fed back as an argument into the same closure/function (recursion — detected via the closure's by-refuseself-reference or a function's own name). Using an element as the container again is a strong tell for anArrayAccesstree, not a plain array.Conservative: only this recursive-feed shape is skipped; the existing changing fixtures are unaffected.