Skip to content

Fix incorrect chapter numbers returned from usfm_structure_extractor#315

Open
pmachapman wants to merge 1 commit into
mainfrom
fix_get_chapters
Open

Fix incorrect chapter numbers returned from usfm_structure_extractor#315
pmachapman wants to merge 1 commit into
mainfrom
fix_get_chapters

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Fixes #308


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit June 18, 2026 01:23
@codecov-commenter

codecov-commenter commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.70%. Comparing base (828bb4d) to head (57f7230).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   90.39%   91.70%   +1.31%     
==========================================
  Files         355      359       +4     
  Lines       22843    23473     +630     
==========================================
+ Hits        20648    21525     +877     
+ Misses       2195     1948     -247     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I understand better how we missed this. I was puzzled how we could have had a bug that wasn't caught when this is so well-tested. Thanks for doing this, Peter!

@Enkidu93 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@Enkidu93 Enkidu93 requested a review from mshannon-sil June 18, 2026 14:18

@mshannon-sil mshannon-sil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thanks Peter! I confirmed that fixes it where it's needed in SILNLP as well.

@mshannon-sil reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix get_chapters() method in DenormalizeQuotationMarksPostprocessor

4 participants