Fix incorrect chapter numbers returned from usfm_structure_extractor#315
Fix incorrect chapter numbers returned from usfm_structure_extractor#315pmachapman wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 90.39% 91.70% +1.31%
==========================================
Files 355 359 +4
Lines 22843 23473 +630
==========================================
+ Hits 20648 21525 +877
+ Misses 2195 1948 -247 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
I understand better how we missed this. I was puzzled how we could have had a bug that wasn't caught when this is so well-tested. Thanks for doing this, Peter!
@Enkidu93 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
mshannon-sil
left a comment
There was a problem hiding this comment.
Thanks Peter! I confirmed that fixes it where it's needed in SILNLP as well.
@mshannon-sil reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
Fixes #308
This change is