[FEATURE] Introduce generic element retrieval helpers#36
Merged
Conversation
beatrycze-volk
added
maintenance
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
beatrycze-volk
force-pushed
the
parameters2
branch
from
f9a7892 to
066ef00
Compare
beatrycze-volk
changed the title
beatrycze-volk
added
feature
Extracts common patterns for fetching single and multiple XML elements into new `getElement()` and `getElements()` helper methods in `BaseElement`. This reduces code duplication across various element-specific getter methods, enhancing maintainability and extensibility. Redundant private helper methods are removed from `BaseNameElement` by leveraging these new generic methods.
beatrycze-volk
force-pushed
the
parameters2
branch
from
066ef00 to
c3ef003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts common patterns for fetching single and multiple XML elements into new
getElement()andgetElements()helper methods inBaseElement.This reduces code duplication across various element-specific getter methods, enhancing maintainability and extensibility. Redundant private helper methods are removed from
BaseNameElementby leveraging these new generic methods.