mbp-1043: gate client_id injection on Entra ID provider#157
Open
p-rog wants to merge 1 commit into
Open
Conversation
The AzureClientIdRequestFilter in qtodo unconditionally injects client_id into OIDC token exchange requests. This breaks Keycloak's federated-jwt authenticator because it requires client_id to match the JWT sub claim (the SPIFFE ID), not the OIDC client ID. Set QTODO_OIDC_INJECT_CLIENT_ID=true only when the OIDC provider is entraid, keeping the filter inactive for Keycloak deployments. Depends-on: validatedpatterns-demos/qtodo (AzureClientIdRequestFilter must read qtodo.oidc.inject-client-id, defaulting to false) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The qtodo AzureClientIdRequestFilter fires unconditionally, breaking Keycloak OIDC authentication with a "client_id parameter does not match sub claim" error. The filter is only needed for Azure Entra ID, where the OIDC provider requires client_id alongside client_assertion.
Fix: Set QTODO_OIDC_INJECT_CLIENT_ID=true in the qtodo ConfigMap only when .Values.app.oidc.provider is "entraid". Keycloak deployments (the default) are unaffected — the env var is not set, and the filter defaults to inactive.
Changed file:
• charts/qtodo/templates/app-config-env.yaml — added QTODO_OIDC_INJECT_CLIENT_ID: "true" inside the existing {{- if eq .Values.app.oidc.provider "entraid" }} block
Depends on: validatedpatterns-demos/qtodo#9